feat: migrate to scikit-build-core
#7
Conversation
| OUTPUT_STRIP_TRAILING_WHITESPACE) | ||
| else() | ||
| set(CASADI_DIR $ENV{CASADI_PATH}) | ||
| message("it is alr set: ${CASADI_DIR}") |
There was a problem hiding this comment.
This is not a good message for printing, please clean this up
There was a problem hiding this comment.
Oh, I forgot to change this. Thanks
| if(DEFINED ENV{CIBUILDWHEEL}) | ||
| install(TARGETS idaklu DESTINATION "pybammsolvers") | ||
| else() | ||
| install(TARGETS idaklu DESTINATION "${CMAKE_CURRENT_SOURCE_DIR}/src/pybammsolvers") | ||
| endif() |
There was a problem hiding this comment.
We should be consistent about where files are placed whenever possible
| "numpy<2.0" | ||
| ] | ||
| license = { file = "LICENSE" } | ||
| version = "0.0.1" |
There was a problem hiding this comment.
Why can't version be dynamic anymore?
There was a problem hiding this comment.
The thing is, scikit-build-core has 3 built-in plugins for dynamic metadata.
The one used for versioning is setuptools_scm, and when I tried using it, it gave out responses similar to: 0.0.1.dev143+81. I tried tweaking it a bit and I found that we might have to use git tags. So I opted for manual version, instead of dynamic.
LMK if you are okay with that default scheme, I can change it.
There was a problem hiding this comment.
I'd very much like to use VCS-based versioning (it's better in many scenarios), but better to avoid it in this PR and proceed with the metadata updates later.
| where = ["src"] | ||
| include = ["pybammsolvers"] | ||
| [tool.hatch.metadata.hooks.fancy-pypi-readme] | ||
| content-type = "text/markdown" | ||
|
|
There was a problem hiding this comment.
Why are we using hatch here when the rest is scikit-build-core?
There was a problem hiding this comment.
scikit-build-core ships with 3 built-in plugins for dynamic metadata. One of them is hatch, and we need to use it if we want a dynamic readme.
| [[tool.hatch.metadata.hooks.fancy-pypi-readme.fragments]] | ||
| path = "README.md" |
There was a problem hiding this comment.
As explained above, we need to use hatch if we want a dynamic readme.
style: format code Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
This pull request will migrate the build backend from "setuptools" and "wheel" to "scikit-build-core" along will the updated workflows.