Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support float_mode='decimal' #116

Merged
merged 3 commits into from
Jul 2, 2024
Merged

support float_mode='decimal' #116

merged 3 commits into from
Jul 2, 2024

Conversation

samuelcolvin
Copy link
Member

fix #108

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably have been a separate RP, but I was flying at the time.

The big change here is to benchmark with all the examples from rust benchmarks, which in turn means the PGO has more run data to work with.

Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #116 will degrade performances by 10.62%

Comparing return-decimal (b74e534) with main (b613634)

Summary

❌ 1 regressions
✅ 72 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main return-decimal Change
true_array_jiter_skip 4.5 µs 5 µs -10.62%

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Files Patch % Lines
crates/jiter/src/py_lossless_float.rs 76.92% 3 Missing ⚠️
crates/jiter/src/errors.rs 0.00% 1 Missing ⚠️
crates/jiter/src/python.rs 96.77% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samuelcolvin samuelcolvin merged commit 6c0a187 into main Jul 2, 2024
22 of 23 checks passed
@samuelcolvin samuelcolvin deleted the return-decimal branch July 2, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: extend lossless_floats to support direct creating of Decimal
2 participants