Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SmallVec and LazyIndexMap from json value #184

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidhewitt
Copy link
Collaborator

Possible alternative to #131.

Pushing to the pipeline to get feedback, locally this seems very similar on perf.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 46.15%. Comparing base (4cefa8b) to head (7cff228).

Files with missing lines Patch % Lines
crates/jiter/src/value.rs 0.00% 44 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4cefa8b) and HEAD (7cff228). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (4cefa8b) HEAD (7cff228)
7 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #184       +/-   ##
===========================================
- Coverage   88.71%   46.15%   -42.57%     
===========================================
  Files          13       12        -1     
  Lines        2207     2004      -203     
  Branches     2207     2004      -203     
===========================================
- Hits         1958      925     -1033     
- Misses        153     1037      +884     
+ Partials       96       42       -54     
Files with missing lines Coverage Δ
crates/jiter/src/value.rs 0.00% <0.00%> (-81.11%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cefa8b...7cff228. Read the comment docs.

Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #184 will not alter performance

Comparing dh/simpler-value (7cff228) with main (4cefa8b)

Summary

✅ 73 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant