Add unix_timestamp_offset to TimeConfig

[adriangb]

Fix #41.

[adriangb]

please review

[codecov]

Codecov Report

Merging #45 (96d31a1) into main (ed75c5b) will decrease coverage by 0.11%.
The diff coverage is 93.93%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   99.17%   99.07%   -0.11%     
==========================================
  Files           6        6              
  Lines         847      862      +15     
==========================================
+ Hits          840      854      +14     
- Misses          7        8       +1     

Impacted Files	Coverage Δ
src/lib.rs	91.66% <0.00%> (-8.34%)	⬇️
src/time.rs	97.51% <92.30%> (+0.07%)	⬆️
src/datetime.rs	100.00% <100.00%> (ø)
src/duration.rs	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed75c5b...96d31a1. Read the comment docs.

[samuelcolvin]

I think this should be unix_tz a bool or enum with two options.

[adriangb]

or enum with two options

It is an enum with two options

[dmontagu]

I think this should be unix_tz a bool or enum with two options.

Do you mean the name of the field on TimeConfig? Or something else?

#[derive(Debug, Clone, Default, Copy)]
pub enum DefaultTimeOffset {
    #[default]
    Naive,
    Utc,
}

// ...

#[derive(Debug, Clone, Default)]
pub struct TimeConfig {
    pub microseconds_precision_overflow_behavior: MicrosecondsPrecisionOverflowBehavior,
    pub default_time_offset: DefaultTimeOffset,
}

Are you just suggesting changing default_time_offset to unix_tz?

[samuelcolvin]

If the input is a number or a numeric string both of which are interpreted as Unix timestamps, then this setting should decide if the timezone is None or Some(0).

Hence the struct member name should change to unix_tz.

[adriangb]

Is this what you mean? d39415f#diff-cc856031f5a2bd26067d2ed100ee6e0dc576d5ed7c354a6f223468b7e5b85664

[samuelcolvin]

I think this should be removed.

[adriangb]

please review

[davidhewitt]

Seems good to me but best to wait for @samuelcolvin to confirm as they have a clear idea of what needs to happen.