Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_trompt.py #373

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix test_trompt.py #373

merged 1 commit into from
Mar 6, 2024

Conversation

weihua916
Copy link
Contributor

@weihua916 weihua916 commented Mar 6, 2024

stype_encoder_dicts needs to be initialized inside test_trompt(). otherwise, it will be persisted across different parametrization, causing an unexpected error.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (56f687d) to head (88b8899).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files         122      122           
  Lines        6398     6401    +3     
=======================================
+ Hits         5979     5982    +3     
  Misses        419      419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weihua916 weihua916 merged commit e774718 into master Mar 6, 2024
14 of 16 checks passed
@weihua916 weihua916 deleted the fix-trompt-test branch March 6, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants