Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MLP normalization argument #377

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Fix MLP normalization argument #377

merged 3 commits into from
Mar 14, 2024

Conversation

weihua916
Copy link
Contributor

@weihua916 weihua916 self-assigned this Mar 11, 2024
@github-actions github-actions bot added the nn label Mar 11, 2024
@weihua916 weihua916 requested a review from rusty1s March 11, 2024 18:37
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (96bdf12) to head (ff908ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         124      124           
  Lines        6451     6454    +3     
=======================================
+ Hits         6033     6036    +3     
  Misses        418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weihua916
Copy link
Contributor Author

@rusty1s Can I get a quick approval?

torch_frame/nn/models/mlp.py Outdated Show resolved Hide resolved
@weihua916 weihua916 merged commit c1f0cb8 into master Mar 14, 2024
14 checks passed
@weihua916 weihua916 deleted the mlp_fix branch March 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants