Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DataFrameTextBenchmark script pos_weight optional #379

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

zechengz
Copy link
Member

Make DataFrameTextBenchmark script pos_weight optional as some datasets may not need this (such as kick)

@zechengz zechengz requested a review from weihua916 March 15, 2024 21:36
@zechengz zechengz self-assigned this Mar 15, 2024
@zechengz zechengz marked this pull request as ready for review March 15, 2024 21:36
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (0cb4d7f) to head (14c9902).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         124      124           
  Lines        6454     6454           
=======================================
  Hits         6036     6036           
  Misses        418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zechengz zechengz requested a review from vid-koci March 15, 2024 21:39
@zechengz zechengz merged commit 5345eea into master Mar 15, 2024
17 checks passed
@zechengz zechengz deleted the zecheng_text_benchmark_pos_weight branch March 15, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants