Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text dataset stats and benchmark materialize return #380

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

zechengz
Copy link
Member

@zechengz zechengz commented Mar 15, 2024

Fix text dataset stats and benchmark dataset materialize return

@zechengz zechengz requested a review from weihua916 March 15, 2024 22:23
@zechengz zechengz self-assigned this Mar 15, 2024
@zechengz zechengz marked this pull request as ready for review March 15, 2024 22:23
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (5345eea) to head (6382c55).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         124      124           
  Lines        6454     6456    +2     
=======================================
+ Hits         6036     6038    +2     
  Misses        418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weihua916 weihua916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zechengz zechengz merged commit 2acfc8c into master Mar 16, 2024
18 checks passed
@zechengz zechengz deleted the zecheng_fix_text_stats_and_materialize branch March 16, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants