Fix offset in LinearEmbeddingEncoder #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 93.58% 93.40% -0.18%
==========================================
Files 126 126
Lines 6592 6615 +23
==========================================
+ Hits 6169 6179 +10
- Misses 423 436 +13 ☔ View full report in Codecov by Sentry. |
akihironitta
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Great catch!
I removed the changelog entry as this bug introduced in #432 hasn't appeared in any releases yet.
Thank you for sharing your suggestion here. The paper uses an older version of PyTorch Frame, so there's no need to double-check the results in the paper. |
|
cc @yiweny for visibility in case you're running some benchmarks with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the
LinearEmbeddingEncoderclass. The forward function does not increment thestart_idxvariable, so only the first one is used correctly if multiple embedding columns are present.This probably affects the results in the RelBench paper, so I suggest double-checking those.