-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workarounds now that sparse-0.9.1 has numba support #229
base: master
Are you sure you want to change the base?
Conversation
039f924
to
821d11d
Compare
821d11d
to
2ceacc7
Compare
This looks exciting, really nice @eric-wieser ! Is there any impact on performance? |
Who knows? We don't really have any canonical benchmarks. |
Mac CI is failing because |
Hmm, seems ~1.4x slower to startup: With this patch
Without this patch:
@stuartarchibald, can you think of why this would be the case? |
Multiplication hasn't really changed:
before:
|
@eric-wieser perhaps this: numba/numba#4927 ? |
The before and after measurements are done with the same dependency versions, and are after numba and sparse have already been imported - it seems that the compilation time is where the cost comes from. |
Ah, could well be, there's some degree of caching available |
Before this patch:
After this patch:
|
@eric-wieser So it actually comes out faster? |
No - note the |
xref pydata/sparse#307