Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper for mapping between different algebras which share basis lades #300

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-wieser
Copy link
Member

TODO:

  • Tests
  • Check docs

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@lgtm-com
Copy link

lgtm-com bot commented Apr 3, 2020

This pull request introduces 3 alerts when merging a1c710c into 26c333c - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Wrong number of arguments in a call

@lgtm-com
Copy link

lgtm-com bot commented Apr 4, 2020

This pull request introduces 1 alert when merging 2ddd7b6 into 26c333c - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a call

… blades

This doesn't work yet, there are sign issues
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #300 into master will decrease coverage by 34.37%.
The diff coverage is 34.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #300       +/-   ##
===========================================
- Coverage   62.71%   28.34%   -34.38%     
===========================================
  Files          57       57               
  Lines        7692     7833      +141     
  Branches     1064     1081       +17     
===========================================
- Hits         4824     2220     -2604     
- Misses       2725     5557     +2832     
+ Partials      143       56       -87
Impacted Files Coverage Δ
clifford/__init__.py 52.32% <100%> (-20.35%) ⬇️
clifford/_blademap.py 25.68% <21.68%> (-29.16%) ⬇️
clifford/test/test_bit_helpers.py 38.29% <43.24%> (-61.71%) ⬇️
clifford/_bit_helpers.py 64.91% <57.14%> (-7.51%) ⬇️
clifford/g2c.py 0% <0%> (-100%) ⬇️
clifford/g3_1.py 0% <0%> (-100%) ⬇️
clifford/_parser.py 0% <0%> (-100%) ⬇️
clifford/g2.py 0% <0%> (-100%) ⬇️
clifford/g3.py 0% <0%> (-100%) ⬇️
clifford/g4.py 0% <0%> (-100%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c333c...cd91459. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant