Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add script to build lock file with Docker #70

Merged
merged 11 commits into from
Oct 13, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 13, 2023

Resolves #59

* Add lock.sh which uses a specified Docker image to build
  the lock file in to avoid operating system differences.
   - Nox is hard to work with in Docker, so use a manually typed
     set of shell commands over attempting to use nox inside the
     container.
   - Allow for emulation of linux/amd64 if docker runtime is other platform.
* Don't use full path in noxfile to avoid adding noise with local test
  builds.
* Add docker target to noxfile.
* Rebuild lock file using lock.sh.
* Update binder/runtime.txt to Python 3.10 to match the same runtime as the
  image that contains ROOT.
* Add build instructions to README.

@matthewfeickert matthewfeickert added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 13, 2023
@matthewfeickert matthewfeickert self-assigned this Oct 13, 2023
@matthewfeickert matthewfeickert merged commit 4b88814 into main Oct 13, 2023
4 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-docker-lock branch October 13, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Docker to build lock file
1 participant