-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Harpy naming capabilities #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoschD
added
the
Type: Feature
A (suggetion for a) new feature or enhancement in functionality.
label
Nov 23, 2023
JoschD
added
Domain: GUI
Closely related to GUI and/or needs GUI changes as well.
and removed
Domain: GUI
Closely related to GUI and/or needs GUI changes as well.
labels
Nov 27, 2023
Mael-Le-Garrec
requested changes
Nov 28, 2023
fsoubelet
reviewed
Nov 29, 2023
fsoubelet
approved these changes
Nov 29, 2023
Code Climate has analyzed commit 5280596 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.9%. View more on Code Climate. |
Mael-Le-Garrec
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a suffix-parameter to harpy, so that the user can change the output filename for the analysis files.
I was considering making it so, that you can specify the full filename... but I think adding only a suffix is okay for now.