Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Harpy naming capabilities #431

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Extend Harpy naming capabilities #431

merged 8 commits into from
Nov 29, 2023

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Nov 23, 2023

Adds a suffix-parameter to harpy, so that the user can change the output filename for the analysis files.
I was considering making it so, that you can specify the full filename... but I think adding only a suffix is okay for now.

@JoschD JoschD added the Type: Feature A (suggetion for a) new feature or enhancement in functionality. label Nov 23, 2023
@JoschD JoschD self-assigned this Nov 23, 2023
@JoschD JoschD marked this pull request as ready for review November 27, 2023 17:14
@JoschD JoschD added Domain: GUI Closely related to GUI and/or needs GUI changes as well. and removed Domain: GUI Closely related to GUI and/or needs GUI changes as well. labels Nov 27, 2023
omc3/hole_in_one.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@JoschD JoschD requested a review from fsoubelet November 29, 2023 12:36
Copy link

codeclimate bot commented Nov 29, 2023

Code Climate has analyzed commit 5280596 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 96.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.9%.

View more on Code Climate.

@JoschD JoschD merged commit 3aea40d into master Nov 29, 2023
35 checks passed
@JoschD JoschD deleted the harpy_file_suffix branch November 29, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants