Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some kmod scripts added #438

Closed
wants to merge 7 commits into from
Closed

Some kmod scripts added #438

wants to merge 7 commits into from

Conversation

fscarlier
Copy link
Contributor

I added 3 scripts for kmod stuff. They all operate separately with input opts for now, and don't affect omc3 tools. They could be merged in some way later with the GUI I guess. If merged later, we might need to remove the strict=True in the entrypoint

The import_kmod.py scripts is in the corrections dir since that made sense for the global corrections.
The others are in the main dir for now, but feel free to suggest better locations.

import_kmod.py : imports kmod results for global corrections
kmod_averages.py : calculates averages from multiple kmod measurements, plots betas, and outputs them in a specific dir
kmod_lumi**py : calculates the luminosity imbalance between ip1 and ip5

Copy link

codeclimate bot commented Mar 7, 2024

Code Climate has analyzed commit 6405f97 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 9.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.8% (-2.2% change).

View more on Code Climate.

@JoschD
Copy link
Member

JoschD commented Mar 8, 2024

You branched this off of the total-phase-correction branch. Was that on purpose? This might cause problems later when that branch has been merged to master... would be better to rebase on master

@JoschD
Copy link
Member

JoschD commented Apr 22, 2024

Hey @fscarlier . This still needs tests, have you progressed in that regard?

@JoschD
Copy link
Member

JoschD commented Jul 9, 2024

Hey @fscarlier what is the status of these tests? Have you talked to @emaclean or @rogeliotomas that maybe someone else can take over this task if this cannot be done by you?

@fscarlier fscarlier requested a review from a team as a code owner September 25, 2024 08:04
@JoschD
Copy link
Member

JoschD commented Oct 25, 2024

continued in #463

@JoschD JoschD closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants