Fix datetime errors in latest Python #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tetime.tzinfo operations
fsoubelet
added
Type: Bug
JoschD
approved these changes
Jan 6, 2025
|
Code Climate has analyzed commit fb68702 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 75.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cron jobs have picked up that the
.localproperty of ourAccDateTimeraises issues as it tries to do some non-tzinfoinherited comparisons.As far as I could tell this is mostly an annoyance due to subclassing the
datetimeclass. A very simple fix is to simply cast to datetime first (using our own.datetimeproperty) and then ask for.astimezoneas previously).PR is a bit more than that since I took the opportunity of dropping Python 3.9 support for this release (as we did with
tfs-pandas) and solve the mess ofpytablesandnumpy 2.xdependencies.