Remove restore_path() decorator
#2318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
pylint-tested
jacobtylerwalls
changed the title
restore_path() decoratorrestore_path() decorator
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2318 +/- ##
==========================================
- Coverage 92.85% 92.84% -0.01%
==========================================
Files 94 94
Lines 11056 11048 -8
==========================================
- Hits 10266 10258 -8
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Some tests to adjust on Python <=3.9, but otherwise primer result looks reasonable. Still have one unraisable exception though. |
Pierre-Sassoulas
approved these changes
Oct 15, 2023
|
Thanks for the review. I'm going to put this one on hold for now; I might want to go in a different direction if I'm able to narrow down why the pylint primer is so noisy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Reverts 0d4f73d.
Refs pylint-dev/pylint#9138: reduces number of unraisable
ValueErrorexceptions in the python 3.12 pylint primer from 3 to 1. (see result) (EDIT: turns out this "result" is a little indeterminate, though...)There's been churn around this decorator before, but I'm in favor of removing some indirection.