Fix collections.abc import error
#2656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the investigation. Jacob tried to add an astroid brain for collections.abc in astroid 3.3.6 but it's not used during import for reasons I don't understand yet. pylint-dev/pylint#10112 |
KKoukiou
added a commit
to KKoukiou/anaconda
that referenced
this pull request
Dec 16, 2024
python-3.13.1 broke compatibility with pylint. Revert this one the pylint issue [1] is fixed. [1] pylint-dev/pylint#10112 [2] pylint-dev/astroid#2656
rvykydal
pushed a commit
to rvykydal/anaconda
that referenced
this pull request
Dec 17, 2024
python-3.13.1 broke compatibility with pylint. Revert this one the pylint issue [1] is fixed. [1] pylint-dev/pylint#10112 [2] pylint-dev/astroid#2656
|
Superseded by #2657. Thanks for taking a stab at this, you correctly identified this as being an issue with our checks for submodules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
I was looking into the recent
collections.abcimport error with Python 3.13.1 and wanted to share my findings, regardless of whether this gets merged or not. Hopefully this helps in some way.Did some testing locally with Linux environment and noticed the following:
collections.abcis not a frozen module and origin is at/usr/lib/python3.12/collections/abc.pycollections.abcis a frozen moduleNow in the
spec._find_spec, it is searching in the followingsubmodule_path-/usr/lib/python3.13/collections, and giving error when not found. However, we expect it to be unfound as it is a frozen module.There is already existing logic for handling frozen modules in the
ImportlibFinderclass, so perhaps we can utilize that?Closes #XXXX