Fix collections.abc imports on Python 3.13.0 and 3.13.1 (#2657)
#2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test for importing `collections.abc` * Fix issue with importing of frozen submodules
This makes it easier to use less generic annotations with mypy.
for more information, see https://pre-commit.ci
|
We were missing 71f5c0c as it changed some of the variables names. This should do the trick. |
|
@Pierre-Sassoulas Can we release with PyPy failing? |
|
I feel like pypy is failing half the time this days. So it dépends is if it's the usual flakyness or an actual issue. The one I Saw was a user warning not being raised.. |
|
Shall we just merge this and at least try to unblock |
|
Yeah let's fix pylint and fix pypy later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport, conflicts were not so easy to solve, need a real review.