-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bass Diffusion Model #1328
base: main
Are you sure you want to change the base?
Add Bass Diffusion Model #1328
Conversation
Here is a crude implementation of the Bass model. Feel free to take over @juanitorduz I forget why I didn't wrap it in the ModelBuilder. Maybe I was just trying it out and familiarizing myself with the model. Maybe it will be straight forward but I remember having some concern. As for the magnitude of model = Bass(m_scaling=5000)
# Under the hood
m = m_scaling * Prior.create_variable(...) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
==========================================
- Coverage 95.31% 94.58% -0.74%
==========================================
Files 47 48 +1
Lines 4912 4950 +38
==========================================
Hits 4682 4682
- Misses 230 268 +38 ☔ View full report in Codecov by Sentry. |
Thanks @wd60622 ! I will familiarize myself with the model and push it forward 🙌 |
Sounds good! Thanks I had the idea we could parameterize it as days/weeks/months from product launch making pooling across dims / products easier. I feel like that would be an interesting insight. |
Description
Adding Bass Diffusion Model
Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--1328.org.readthedocs.build/en/1328/