-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Budget optimizer refactor #1357
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
0196b3a
to
6c946f2
Compare
3a348d2
to
10b0783
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1357 +/- ##
===========================================
- Coverage 95.31% 55.53% -39.79%
===========================================
Files 47 47
Lines 4912 4921 +9
===========================================
- Hits 4682 2733 -1949
- Misses 230 2188 +1958 ☔ View full report in Codecov by Sentry. |
yay! 🚀 Let me know if you need any support! |
10b0783
to
36985c4
Compare
Why does this have a CLV label? |
Seems like from file change bot. Then the force push made any clv files have no changes. I removed the clv label |
This PR refactors the budget optimizer to extract the response graph from the MMM model directly. The users don't have to pass the arguments needed to rebuild the response function, which simplifies things quite a lot and makes the optimizer able to handle arbitrarily complex models [citation needed]
Breaking changes:
TODO:
Closes #1331
📚 Documentation preview 📚: https://pymc-marketing--1357.org.readthedocs.build/en/1357/