Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new evaluation notebook #1374

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Fix new evaluation notebook #1374

merged 4 commits into from
Jan 15, 2025

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Jan 14, 2025

Closes #1372

  • Harmonize colors
  • Fix titles being shifted in the prior - posterior plots
  • Watermark
  • Harmonize numpy type hints.

FYI @louismagowan :)


📚 Documentation preview 📚: https://pymc-marketing--1374.org.readthedocs.build/en/1374/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM labels Jan 14, 2025
@juanitorduz juanitorduz requested a review from wd60622 January 14, 2025 20:51
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.92%. Comparing base (7986a9c) to head (7deef59).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/mmm/mmm.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   93.86%   93.92%   +0.05%     
==========================================
  Files          48       48              
  Lines        5135     5133       -2     
==========================================
+ Hits         4820     4821       +1     
+ Misses        315      312       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanitorduz

@wd60622 wd60622 merged commit 16db682 into main Jan 15, 2025
19 of 20 checks passed
@wd60622 wd60622 deleted the fix_eval_nb branch January 15, 2025 08:45
@louismagowan
Copy link
Contributor

Thanks @juanitorduz! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation maintenance MMM no releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmm_evaluation notebook failure
3 participants