Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a type error to test tsc ci job #144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented May 3, 2024

No description provided.

@hoodmane
Copy link
Member Author

hoodmane commented May 3, 2024

@ryanking13 any idea how to fix the "Error: Resource not accessible by integration" in the check ts job?

@ryanking13
Copy link
Member

ryanking13 commented May 5, 2024

Pull requests from the forked repositories have a limit to writing permissions. (You can see the permission of the GITHUB TOKEN in "setup jobs" step)

image

So, I think we should make an action that uses the "workflow_run" trigger to run this check. The workflow_run action runs under the original repository, so it has write permission. We already use that approach in test_report.yaml action.

This blog post has some more details about it: https://blog.nimblepros.com/blogs/using-workflow-run-in-github-actions/

@hoodmane
Copy link
Member Author

hoodmane commented May 5, 2024

Thanks, I'll try that. Really feels like GitHub should fix it so that actions have the right to post outcome information somewhere without this complicated setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants