feat: adding enable #2048
Open
feat: adding enable #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Oct 19, 2024
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
d7329df
to
a70d4b3
Compare
Merged
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
a70d4b3
to
8a54c9f
Compare
henryiii
force-pushed
the
henryiii/feat/enable
branch
2 times, most recently
from
cc80f2c
to
bbc0a19
Compare
mayeut
reviewed
Nov 2, 2024
Comment on lines
+632
to
+642
| # For backwards compatibility, we are adding PyPy for now | ||
| enable |= {EnableGroups.PyPy} |
There was a problem hiding this comment.
I guess this is where the question of !pypy came from ?
I hadn't read the PR just yet when replying and it seems having the ! operator would invalidate the current implementation.
The idea would thus be to keep PyPy enabled in 2.22 but change the default to disabled in 3.0 ?
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
bbc0a19
to
e2c5f24
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
e2c5f24
to
17df90f
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2045. Adds
enable, deprecates the old way of specifying these (remove in 3.0).