-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add musllinux_1_2_armv7l #1455
Conversation
6455e8a
to
e59ac58
Compare
If you need help with this - I can try to help |
f05ee64
to
cd1ae7e
Compare
9ffa09b
to
9652383
Compare
Tanks for the proposition and sorry for the long silence, I wanted to get a clearer picture before asking for help. The blockers for this are all related to The first step would be to confirm that they can be considered the same and if you can help with that, it would be greatly appreciated. If they can't be considered the same - in this context -, there's really not much that can be done IMHO. If they can be considered the same, auditwheel shall remap armv8l to armv7l In any case, pip / packaging shall allow installation of armv7l packages on armv8l (maybe related to pypa/packaging#476) |
if [ "$(linux32 uname -m)" == "armv8l" ]; then | ||
export _PYTHON_HOST_PLATFORM="linux_armv7l" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really a hugly hack and should not be required for the image to be usable IMHO.
docker/build_scripts/finalize.sh
Outdated
if [ "${AUDITWHEEL_PLAT}" == "musllinux_1_1_armv7l" ]; then | ||
case ${TOOL} in | ||
swig) apk add --no-cache swig; continue;; | ||
cmake) apk add --no-cache cmake; continue;; | ||
esac | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only be temporary.
Probably I do not understand the question.
How armv7l build supposed to work on armv8l? Maybe here I am not understand, did you mean by If someone will install 32 bit Python on Alpine 64-bit, then only in that case it will use |
4b34467
to
a5a1497
Compare
ARM v8 is a microarchitecture https://en.wikipedia.org/wiki/ARM_architecture_family#Armv8 that supports both 32-bit and 64-bit ISA (some chips are only 32-bit, some only 64-bit).
The linux kernel reports Here we leverage the fact that AWS Graviton 2 can indeed run 32-bit code in user-space (we use an armv7 base image). The fact that |
a14fc3b
to
4f4ded0
Compare
4f4ded0
to
45c4d34
Compare
df0ce0f
to
4a180a0
Compare
2c10c8d
to
f85a8ff
Compare
f85a8ff
to
e285760
Compare
cfe2c8b
to
058e17c
Compare
This reverts commit 3e2af24.
Let's merge this & see if we get feedback on the armv8l vs armv7l comment that remains. |
No description provided.