-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with distutils #4790
Merged
Merged
Sync with distutils #4790
+28
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Python 3.13 on Windows, `os.path.isabs()` no longer returns `True` for a path that starts with a slash. Thus, when the argument to `_make_relative()` is an absolute path, the return value starts with a slash on Python 3.13 and does not start with a slash on older Python versions. This causes the extension module build directory to be calculated incorrectly with Python 3.13 on Windows. Fix this by ensuring that the return value does not start with a slash.
Co-authored-by: Avasam <samuel.06@hotmail.com>
Followup to af7fcbb. I accidentally left that in when trying two approaches. Reported at pypa/distutils#322 (comment).
…ss-python compatibility.
Fix issue with absolute path with Python 3.13 on Windows
Don't duplicate CFLAGS
jaraco
force-pushed
the
feature/distutils-ff11eed0c
branch
from
January 5, 2025 15:33
83f4b86
to
5ed9d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterable
at runtime forExtension
os.fspath
for type checkingPy_GIL_DISABLED=1
for free threading on WindowsTypeError
instead ofAssertionError
Distribution.get_command_obj
to not returnNone
withcreate=True
Summary of changes
Closes #4669
Pull Request Checklist
newsfragments/
.(See documentation for details)