Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove egg and wininst support #1195

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

dnicolodi
Copy link
Contributor

PyPI does not accept these distribution types since August 2023 and there are no modern build backends that produce these, thus they are most likely not used anymore.

egg support has only very minimal test coverage and had a fairly obvious although likely inconsequential bug in reporting the target Python version. wininst support has no tests.

@dnicolodi
Copy link
Contributor Author

As discussed in #1190 (comment). Replaces #1192.

@dnicolodi dnicolodi force-pushed the rm-egg-wininst branch 2 times, most recently from 50be486 to 7022e65 Compare December 4, 2024 21:29
@woodruffw
Copy link
Member

Thanks @dnicolodi -- like with #1191, could you add a small test here?

A simple negative/backstop test to ensure that twine produces a reasonable error message for these now-unsupported filetypes would be sufficient IMO.

@dnicolodi
Copy link
Contributor Author

I will jump through the hoop, just for the sake of getting this moving. However, this PR does not change how unrecognized files are handled thus I don't see why only now it becomes important that this aspect is tested...

@dnicolodi
Copy link
Contributor Author

Test added.

@woodruffw
Copy link
Member

Thanks.

However, this PR does not change how unrecognized files are handled thus I don't see why only now it becomes important that this aspect is tested...

I'm a big believer in negative tests -- I think they make it easier to detect regressions and other unplanned changes. The fact that there wasn't a negative test here already isn't a good reason to not add one IMO 🙂

@woodruffw woodruffw self-assigned this Dec 4, 2024
changelog/1195.misc.txt Outdated Show resolved Hide resolved
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, otherwise LGTM, thank you!

PyPI does not accept these distribution types since August 2023 and
there are no modern build backends that produce these, thus they are
most likely not used anymore.

egg support has only very minimal test coverage and had a fairly
obvious although likely inconsequential bug in reporting the target
Python version. wininst support has no tests.
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnicolodi!

@woodruffw woodruffw merged commit 55854b7 into pypa:main Dec 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants