packaging: deletion window machinery #16813
Draft
+153
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `in_deletion_window` to the File, Release, and Project models. The three models currently compose in deletion semantics as follows: 1. A file is deletable iff it was uploaded within the last 7 days 2. A release is deletable iff all of its files are deletable 3. A project is deletable iff all of its releases are deletable This results in no special casing: the deletability of releases and projects is entirely "driven" by the deletability of files, as files are the primary way in which users drive the creation of releases and projects. This PR does **not** connect the deletion semantics to actual UI or view changes; I'll do that in a follow-up, to keep the patches small. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
|
Added some changes to reflect the current PEP 763 draft. Specifically:
Relevant section from the PEP:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
in_deletion_windowto the File, Release, and Project models. The three models currently compose in deletion semantics as follows:This results in no special casing: the deletability of releases and projects is entirely "driven" by the deletability of files, as files are the primary way in which users drive the creation of releases and projects.
This PR does not connect the deletion semantics to actual UI or view changes; I'll do that in a follow-up, to keep the patches small.