Issue 6688: Added project, role and initiator user URLs to email #16975
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have executed |
di
reviewed
Nov 21, 2024
Comment on lines
+27
to
+29
| Project "{{ project_name }}" details: https://pypi.org/project/{{ project_name }} | ||
| Role "{{ role }}" details: https://pypi.org/help/#collaborator-roles | ||
| Added by {{ initiator_username }}: https://pypi.org/user/{{ initiator_username }} |
There was a problem hiding this comment.
A few things here:
First, these should use request.route_url(...) to generate the links, for example:
request.route_url('accounts.profile', username=initiator_username)Second, these should be inline links within the message body, like:
you have been added by <a href="{{ request.route_url('accounts.profile', username=initiator_username) }}">{{ initiator_username }}</a> to a projectAnd not added at the end.
<a href="
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6688
NOTE:
I'm working on a machine with 4GB RAM, and the
make servestep failed due to timeout. However, since the patch only involved minor additions to Jinja2 templates, I proceeded with the submission despite not fully testing it. I understand this isn't ideal, but the fix appeared straightforward.