Draw bbox #118
Draw bbox #118
Conversation
|
We have a bandit error because of try catch in loop for update_live_alerts_data call back I propose to manage it out of this PR |
MateoLostanlen
force-pushed
the
draw_bbox
branch
from
15799cb to
dcf7701
Compare
There was a problem hiding this comment.
Hi @MateoLostanlen, thanks a lot for this PR, overall everything seems OK.
Sometimes there is no bbox on detection frames (screenshot bellow), could you explain why ?
Also in this case should we still display the frame as the ticked option seems to be confusing.
app/utils/alerts.py
Outdated
| individual_alert_frame_placeholder_children = [] | ||
| for event_id, frame_url_list in images_url_live_alerts.items(): | ||
| individual_alert_frame_placeholder_children.append( | ||
| html.Div( | ||
| id={"type": "individual_alert_frame_storage", "index": str(event_id)}, | ||
| children=frame_url_list, | ||
| style={"display": "none"}, | ||
| ) | ||
| ) | ||
|
|
There was a problem hiding this comment.
True that it's actually never used, but this means that this Callback is actually creating the div
|
hello @Akilditu , Pyro-engine combines 4 frames to send an alert in order to reduce FP rate. The box we display is the prediction of the model on each frame, if the model do not detect anything there is no box |
MateoLostanlen
force-pushed
the
draw_bbox
branch
from
dcf7701 to
9f2857b
Compare
MateoLostanlen
force-pushed
the
draw_bbox
branch
from
9f2857b to
9a13153
Compare
There was a problem hiding this comment.
@MateoLostanlen everything seems fine now, one last thing : I understand the 4 frames needed for Pyro Engine but should we still display frames on which there is no box / detection ?
I understand that this would somehow break the 'detection flow' that shows the fire evolution but I find it kinda weird to have random frames with and without boxes in between. Feels a bit like the model is messing things up ..
|
@Akilditu I understand your concern about the consistency of the detection flow. However, it's important to consider that every frame, whether it has a detected box or not, contains valuable information about the presence or absence of fire at a given moment. Removing frames without detections could potentially discard subtle cues or indicators that are crucial for a comprehensive understanding of the fire's evolution. Firefighters rely on the full context of an evolving situation. Even frames where the AI does not detect fire can serve as negative data points that contribute to the overall pattern of the event. These 'empty' frames can act as confirmation that the fire has not spread to certain areas at specific times, which is just as important as knowing where the fire is active. Therefore, keeping all frames ensures that firefighters get the complete picture, which is essential for their safety and the effectiveness of their response. It is better to err on the side of providing too much information rather than too little in such critical applications. |
The PR to display the prediction the firefighters wanted!
I've added a button to toggle the prediction on or off for a better view in the case of a small fire.
I've removed the question "Is the alert relevant?", which is redundant with the question below, to free up space.
I'm going to update the devices with the latest version of engine so that they all send the prediction.