Instantiate n_click of acknowledge button to 0 instead of 1

[vanderlindenma]

WHAT'S THE ISSUE

Before this PR we have:

pyro-platform/app/pages/homepage.py

Lines 115 to 118 in 68a6bce

	dbc.Button(
	"Acquitter l'alerte",
	id="acknowledge-button",
	n_clicks=1,

but

pyro-platform/app/callbacks/display_callbacks.py

Lines 470 to 494 in 68a6bce

	@app.callback(
	Output("to_acknowledge", "data"),
	[Input("acknowledge-button", "n_clicks")],
	[
	State("event_id_on_display", "data"),
	State("user_headers", "data"),
	State("user_credentials", "data"),
	],
	prevent_initial_call=True,
	)
	def acknowledge_event(n_clicks, event_id_on_display, user_headers, user_credentials):
	"""
	Acknowledges the selected event and updates the state to reflect this.
	Parameters:
	- n_clicks (int): Number of clicks on the acknowledge button.
	- event_id_on_display (int): Currently displayed event ID.
	- user_headers (dict): User authorization headers for API requests.
	- user_credentials (tuple): User credentials (username, password).
	Returns:
	- int: The ID of the event that has been acknowledged.
	"""
	if event_id_on_display == 0 or n_clicks == 0:
	raise PreventUpdate

The intention behind n_clicks == 0 => PreventUpdate seems to be making sure that an alert is not acknowledged when the app loads. But that cannot work given that "acknowledge-button" is instantiated to have n_clicks = 1.

WHY DOES IT MATTER IF WE HAVE prevent_initial_call=True anyways?

Preventing acknowledgment on load is indeed already covered by prevent_initial_call=True.

However, prevent_initial_call=True does not cover accidental runs on redirect.

We have:

pyro-platform/app/layouts/main_layout.py

Line 31 in 68a6bce

dcc.Location(id="url", refresh=False),

which implies upon url redirects Dash (/the underlying React engine) attempts to catch redirects triggered within the app and modify pages minimally instead of fully reloading a page.

As I understand the Dash/React lifecycle, this implies redirects triggered within the app do not count as page reloads =>prevent_initial_call=True does not apply to those page reloads
=> Dash re-runs all callbacks (or at least those for which the inputs or states may have changed).
=> At least if the acknowledge button is modified by the redirect (e.g., text translated from #173), it's reinstantiated to n_clicks = 1, the safeguard in the callback does not apply, and the error is acknowledged.

[MateoLostanlen]

good catch