Merge pull request #1318 from sebastiangaiser/main

fix(crd-gen): use correct description for 'spec.indicator.bool_gauge.…
pyrra-dev · Dec 14, 2024 · e991d23 · e991d23
2 parents 56781bd + b0bf752
commit e991d23
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/examples/kubernetes/manifests-webhook/setup/pyrra-slo-CustomResourceDefinition.yaml b/examples/kubernetes/manifests-webhook/setup/pyrra-slo-CustomResourceDefinition.yaml
@@ -88,7 +88,7 @@ spec:
                       successful.
                     properties:
                       grouping:
-                        description: Total is the metric that returns how many requests there are in total.
+                        description: Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
                         items:
                           type: string
                         type: array

diff --git a/examples/kubernetes/manifests/setup/pyrra-slo-CustomResourceDefinition.yaml b/examples/kubernetes/manifests/setup/pyrra-slo-CustomResourceDefinition.yaml
@@ -88,7 +88,7 @@ spec:
                       successful.
                     properties:
                       grouping:
-                        description: Total is the metric that returns how many requests there are in total.
+                        description: Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
                         items:
                           type: string
                         type: array

diff --git a/examples/openshift/manifests/setup/pyrra-slo-CustomResourceDefinition.yaml b/examples/openshift/manifests/setup/pyrra-slo-CustomResourceDefinition.yaml
@@ -88,7 +88,7 @@ spec:
                       successful.
                     properties:
                       grouping:
-                        description: Total is the metric that returns how many requests there are in total.
+                        description: Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
                         items:
                           type: string
                         type: array

diff --git a/jsonnet/controller-gen/pyrra.dev_servicelevelobjectives.json b/jsonnet/controller-gen/pyrra.dev_servicelevelobjectives.json
@@ -99,7 +99,7 @@
                         "description": "BoolGauge is the indicator that measures whether a boolean gauge is\nsuccessful.",
                         "properties": {
                           "grouping": {
-                            "description": "Total is the metric that returns how many requests there are in total.",
+                            "description": "Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.",
                             "items": {
                               "type": "string"
                             },

diff --git a/kubernetes/api/v1alpha1/servicelevelobjective_types.go b/kubernetes/api/v1alpha1/servicelevelobjective_types.go
@@ -172,7 +172,7 @@ type BoolGaugeIndicator struct {
 	Query `json:",inline"`
 
 	// +optional
-	// Total is the metric that returns how many requests there are in total.
+	// Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
 	Grouping []string `json:"grouping"`
 }