Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit defect related triples when operations are performed on the structure #159

Merged
merged 15 commits into from
Aug 15, 2024

Conversation

srmnitc
Copy link
Member

@srmnitc srmnitc commented Aug 15, 2024

will close #158

  • generalise extract triples
  • stop extract triples at derived samples
  • add a new function to create graph from triples
  • modify the get_sample function to work with new setup
  • add function to create new IDs for URIRefs in the extracted graph
  • add function to delete the extracted triples (could be used for removing a sample) (will do in new PR)
  • add copy_defects which copy defect triples to a new structure
  • use this function in workflow.py
  • use this function for all modify methods

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.27%. Comparing base (8eb8265) to head (917e96a).
Report is 25 commits behind head on main.

Files Patch % Lines
atomrdf/graph.py 91.25% 7 Missing ⚠️
atomrdf/structure.py 58.82% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   66.59%   67.27%   +0.68%     
==========================================
  Files          25       25              
  Lines        3550     3618      +68     
==========================================
+ Hits         2364     2434      +70     
+ Misses       1186     1184       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srmnitc srmnitc changed the title clean extract function Inherit defect related triples when operations are performed on box Aug 15, 2024
@srmnitc srmnitc changed the title Inherit defect related triples when operations are performed on box Inherit defect related triples when operations are performed on the structure Aug 15, 2024
@srmnitc srmnitc merged commit 4fbaf5a into main Aug 15, 2024
7 checks passed
@srmnitc srmnitc deleted the inherit_triples branch August 15, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated structures do not have defect-related triples
1 participant