Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change repetitions to [1, 1, 1] if None #168

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Change repetitions to [1, 1, 1] if None #168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dddff51
Change `repetitions` to `[1, 1, 1]` if `Non`
samwaseda Oct 7, 2024
77ec133
Update atomrdf/structure.py
samwaseda Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion atomrdf/structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ def _make_crystal(
s : object
The atomrdf.Structure object representing the generated crystal structure.
"""
if repetitions is None:
repetitions = [1, 1, 1]
atoms, box, sdict = pcs.make_crystal(
structure,
lattice_constant = _declass(lattice_constant),
Expand Down Expand Up @@ -2674,4 +2676,4 @@ def plot3d(self, *args, **kwargs):
ase_structure = self.write.ase()
pyiron_structure = ase_to_pyiron(ase_structure)
return pyiron_structure.plot3d(*args, **kwargs)


samwaseda marked this conversation as resolved.
Show resolved Hide resolved