Add static typechecking with mypy #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffl096
force-pushed
the
frantzen-mypy
branch
2 times, most recently
from
09ec3db to
f360521
Compare
ffl096
force-pushed
the
frantzen-mypy
branch
from
f360521 to
947af52
Compare
|
@ffl096 update on this? Should we close? |
|
There are still many errors in the code base. This pull request is meant to track the progress of that. |
|
Let's get this merged as is for now. There are many typing issues remaining, but most of them are non-trivial to fix. We can keep an eye on it via the GitHub Action (that is allowed to fail) but don't enforce compliance with mypy on TopoNetX for now. |
mhajij
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pull request to track the progress of adding typing annotations to our codebase. For now it is expected that mypy raises errors.