Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dirac operator for CCC #303

Closed
wants to merge 4 commits into from
Closed

adding dirac operator for CCC #303

wants to merge 4 commits into from

Conversation

mhajij
Copy link
Member

@mhajij mhajij commented Nov 2, 2023

No description provided.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ff5a45) 97.29% compared to head (0b8cd3d) 97.31%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   97.29%   97.31%   +0.02%     
==========================================
  Files          29       29              
  Lines        3359     3389      +30     
==========================================
+ Hits         3268     3298      +30     
  Misses         91       91              
Files Coverage Δ
toponetx/classes/combinatorial_complex.py 93.37% <100.00%> (+0.73%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhajij mhajij requested a review from ffl096 November 2, 2023 16:10
Copy link
Member

@ffl096 ffl096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me

Comment on lines 800 to 806
scipy.sparse.csr.csc_matrix | tuple[dict, dict, scipy.sparse.csc_matrix]
The dirac operator matrix, if `index` is False, otherwise
row_indices : dict
List identifying rows and columns of the dirac operator matrix. Only
returned if `index` is True.
scipy.sparse.csr.csc_matrix
The dirac operator matrix of this combinatorial complex.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
scipy.sparse.csr.csc_matrix | tuple[dict, dict, scipy.sparse.csc_matrix]
The dirac operator matrix, if `index` is False, otherwise
row_indices : dict
List identifying rows and columns of the dirac operator matrix. Only
returned if `index` is True.
scipy.sparse.csr.csc_matrix
The dirac operator matrix of this combinatorial complex.
row_indices, col_indices : dict
List identifying rows and columns of the dirac operator matrix. Only
returned if `index` is True.
dirac_matrix : scipy.sparse.csr.csc_matrix
The dirac operator matrix of this combinatorial complex.

@mhajij mhajij closed this Nov 3, 2023
@ffl096 ffl096 deleted the dirac-cc branch February 2, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants