Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move datasets out of repository #384

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

ffl096
Copy link
Member

@ffl096 ffl096 commented Aug 5, 2024

To reduce build size, we do not ship the dataset files with the package anymore. The respective functions automatically download them on first use.

@ffl096 ffl096 self-assigned this Aug 5, 2024
@ffl096 ffl096 added enhancement New feature or request refactor labels Aug 5, 2024
@ffl096 ffl096 added this to the 0.1.0 milestone Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (0e33fad) to head (3444a10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          38       38           
  Lines        3534     3545   +11     
=======================================
+ Hits         3457     3468   +11     
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffl096 ffl096 merged commit 67e58b4 into main Aug 5, 2024
17 checks passed
@ffl096 ffl096 deleted the frantzen/externalize-datasets branch August 5, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant