feat: add publisher program to sync cli #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
force-pushed
the
add-sync-publisher-program
branch
from
a523264
to
8d152f3
Compare
ali-bahjati
force-pushed
the
add-sync-publisher-program
branch
from
8d152f3
to
eb23897
Compare
Riateche
requested changes
Sep 6, 2024
ayazabbas
reviewed
Sep 9, 2024
program_admin/__init__.py
Outdated
| @@ -100,6 +114,12 @@ async def fetch_minimum_balance(self, size: int) -> int: | |||
| async with AsyncClient(self.rpc_endpoint) as client: | |||
| return (await client.get_minimum_balance_for_rent_exemption(size)).value | |||
|
|
|||
| async def account_exists(self, key: PublicKey) -> bool: | |||
There was a problem hiding this comment.
There is already an account_exists function in util.py (it's being imported and used already in this file too)
ayazabbas
approved these changes
Sep 9, 2024
thmzlt
reviewed
Sep 9, 2024
| @@ -16,6 +16,15 @@ | |||
| from program_admin import instructions as pyth_program | |||
| from program_admin.keys import load_keypair | |||
| from program_admin.parsing import parse_account | |||
| from program_admin.publisher_program_instructions import ( | |||
There was a problem hiding this comment.
I think if you use a formatter such as black/ruff it will combine these two import declarations.
There was a problem hiding this comment.
actually it seems that the formatter in pre-commit (black i assume) is breaking them apart. idk why but i can't join them.
Riateche
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.