[entropy] Minor updates to parameters / docs #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
jayantk
commented
Nov 1, 2023
| pub secret: String, | ||
|
|
||
| /// The length of the hash chain to generate. | ||
| #[arg(long = "chain-length")] | ||
| #[arg(env = "FORTUNA_CHAIN_LENGTH")] | ||
| #[arg(default_value = "32")] | ||
| #[arg(default_value = "10000")] |
There was a problem hiding this comment.
update the default argument values to be more reasonable (and stop pointing to my test wallet)
jayantk
commented
Nov 1, 2023
| | avalanche-fuji | 0xD42c7a708E74AD19401D907a14146F006c851Ee3 | 0x368397bDc956b4F23847bE244f350Bde4615F25E | ||
| | optimism-goerli | 0x28F16Af4D87523910b843a801454AEde5F9B0459 | 0x368397bDc956b4F23847bE244f350Bde4615F25E | ||
| | eos-evm-testnet | 0xD42c7a708E74AD19401D907a14146F006c851Ee3 | 0x368397bDc956b4F23847bE244f350Bde4615F25E | ||
| | avalanche-fuji | 0xD42c7a708E74AD19401D907a14146F006c851Ee3 | 0x6CC14824Ea2918f5De5C2f75A9Da968ad4BD6344 |
There was a problem hiding this comment.
update the provider key to the new fortuna-staging key
jayantk
commented
Nov 1, 2023
| | optimism-goerli | 0x075A5160FF6462924B4124595F6f987187496476 | https://goerli.optimism.io | | ||
| | optimism-goerli | 0x3bA217Cd7840Cc5B34FD5B7263Cebd8CD8665788 | https://goerli.optimism.io | | ||
| | avalanche-fuji | 0xE7E52C85907d59C45b2C56EF32B78F514F8c547a | https://api.avax-test.network/ext/bc/C/rpc | | ||
| | eos-evm-testnet | 0x413405Aee2db95cb028B60CBAd87FC0B932947f4 | https://api.testnet.evm.eosnetwork.com/ | |
There was a problem hiding this comment.
I deployed coinflip with the new provider address
jayantk
commented
Nov 1, 2023
| @@ -106,7 +106,7 @@ async function main() { | |||
| // Note that there is a potential race condition here: the server may not have observed the request ^ | |||
| // before this HTTP response. Hence, we retry fetching the url a couple of times. | |||
| const response = await fetchWithRetry(url, 3); | |||
| const providerRandom = web3.utils.bytesToHex(response.value); | |||
| const providerRandom = `0x${response.value.data}`; | |||
There was a problem hiding this comment.
adjust example since this PR changed the API #1129
jayantk
commented
Nov 1, 2023
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "fortuna" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
forgot to bump this version in the previous PR
jayantk
commented
Nov 1, 2023
| @@ -16,8 +16,13 @@ These commands will build dependencies for the typescript project. | |||
| Next, choose a network to run the example on. | |||
| The example has been deployed on the following networks: | |||
|
|
|||
| | Chain Name | Address | RPC | | |||
| | optimism-goerli | 0x075A5160FF6462924B4124595F6f987187496476 | https://goerli.optimism.io | | |||
| ``` | |||
There was a problem hiding this comment.
tables don't format properly in github :(
There was a problem hiding this comment.
You can actually do this with html and there’s some examples out there or GitHub flavoured markdown mixed with HTML if you really want it these.
Reisen
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple minor changes in here. commented inline