[cosmwasm] Use ParsedVaa from wormhole contract #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
commented
Jan 23, 2024
| assert_eq!(result, Ok(true)); | ||
|
|
||
| // insufficient fee in base denom -> false | ||
| info.funds = coins(50, "foo"); | ||
| let result = is_fee_sufficient(&deps, info.clone(), &data); | ||
| let result = is_fee_sufficient(deps, info.clone(), data); |
guibescos
commented
Jan 23, 2024
| @@ -1,46 +0,0 @@ | |||
| // These types are copied from the Wormhole contract. See the links with each type to see the original code | |||
| // The reason to do so was dependency conflict. Wormhole contracts were using a very old version of a dependency | |||
| // which is not compatible with the one used by osmosis-sdk. And since we weren't using anything else from | |||
There was a problem hiding this comment.
Seems like this comment is outdated
guibescos
changed the title
jayantk
approved these changes
Jan 23, 2024
|
Thanks! It would be great if you can run |
ali-bahjati
reviewed
Jan 24, 2024
guibescos
force-pushed
the
cosmwasm/use-wormhole-contract
branch
from
44713ae
to
6b877b9
Compare
This reverts commit 0cb2cae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while playing around with the cosmos contract.
We were copy pasting ParsedVAA and WormholeQueryMsg instead of importing them from cw_wormhole.
The reason for this seems to be incompatiblity with osmosis. However I was able to build properly with osmosis, so it think the reason doesn't exist anymore and we can import from the wormhole crate.