fix(apps/hermes/client): allow baseURL with suffixes #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mubaris is attempting to deploy a commit to the pyth-web Team on Vercel. A member of the Team first needs to authorize it. |
mubaris
changed the title
cctdaniel
reviewed
Jun 25, 2024
| @@ -100,7 +100,7 @@ export class HermesClient { | |||
| query?: string; | |||
| filter?: string; | |||
| }): Promise<PriceFeedMetadata[]> { | |||
| const url = new URL("/v2/price_feeds", this.baseURL); | |||
| const url = new URL(`${this.baseURL}/v2/price_feeds`); | |||
There was a problem hiding this comment.
I think we should keep the current structure but make the path relative e.g.
const url = new URL('v2/price_feeds', baseURL);
The URL constructor ensures that the protocol and host parts of the base URL are preserved correctly, even if the base URL has additional path components.
If you could also make the changes for getLatestPriceUpdates and getPriceUpdatesAtTimestamp that would be appreciated!
cctdaniel
requested changes
Jun 25, 2024
cctdaniel
approved these changes
Jun 25, 2024
|
thanks for your contribution! can you bump the package version? |
|
done! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.