feat(target_chains/ethereum): remove getPrice from IPyth #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ali-bahjati
force-pushed
the
eth/remove-get-price
branch
from
510acc9
to
f42c44d
Compare
ali-bahjati
force-pushed
the
eth/remove-get-price
branch
from
f42c44d
to
415832a
Compare
jayantk
approved these changes
Aug 5, 2024
ali-bahjati
force-pushed
the
eth/remove-get-price
branch
from
415832a
to
007000e
Compare
cprussin
approved these changes
Aug 5, 2024
aditya520
approved these changes
Aug 6, 2024
| @@ -23,18 +23,19 @@ abstract contract AbstractPyth is IPyth { | |||
| public | |||
| view | |||
| virtual | |||
| override | |||
There was a problem hiding this comment.
Can we add the same @notice to getValidTimePeriod() as well?
aditya520
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPrice method uses a configured default staleness from the Pyth contract which is normally set to 60 seconds. While this is enough for some types protocols it's very high for latency-sensitive protocols and protocols should use set their own desired staleness. This change removes this method and getEmaPrice and leaves protocols with getPriceUnsafe or getPriceNoOlderThan.
The contract will still support the getPrice method to avoid breaking existing users of it.