Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote_executor): update eclipse_mainnet #1813

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

cctdaniel
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 1:51pm
xc-admin-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 1:51pm

Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a bug in wrapAsRemoteInstruction.
Also not convinced about the changes to Propose.tsx, they feel too hacky and tbh without the changes it displays just nice.

image

@cctdaniel cctdaniel changed the title feat(xc_admin_frontend): update xc-admin-frontend to show eclipse_mainnet proposals feat(xc_admin_frontend): update xc-admin-frontend Aug 6, 2024
@cctdaniel cctdaniel changed the title feat(xc_admin_frontend): update xc-admin-frontend feat(remote_executor): update eclipse_mainnet Aug 6, 2024
@guibescos guibescos merged commit 5f9e78c into main Aug 6, 2024
7 checks passed
@guibescos guibescos deleted the xc-admin-frontend-eclipse-mainnet branch August 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants