feat(entropy): Limit number of hashes #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jayantk
approved these changes
Aug 12, 2024
| } | ||
|
|
||
|
|
||
| pub async fn update_commitments_if_necessary( |
There was a problem hiding this comment.
nitpick: I think the verb "update" is a bit confusing here because it suggests that the caller could set the commitment to anything they want. A better name would be "advance", which implies that you can only move forward in the same hash chain.
OpenCoreCH
reviewed
Aug 14, 2024
| @@ -38,6 +38,11 @@ interface EntropyEvents { | |||
| address oldFeeManager, | |||
| address newFeeManager | |||
| ); | |||
| event ProviderMaxNumHashesUpdated( | |||
| address provider, | |||
| uint64 oldMaxNumHashes, | |||
There was a problem hiding this comment.
Small detail, but is there a reason that this is a uint64 when the struct field is only a uint32?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.