Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update hermes to support publisher stake caps #1866

Merged
merged 13 commits into from
Sep 4, 2024
Merged

feat: update hermes to support publisher stake caps #1866

merged 13 commits into from
Sep 4, 2024

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Sep 3, 2024 •
edited
Loading

This PR adds a new endpoint /api/get_publisher_stake_caps_update_data for consumption of publisher caps messages

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ❌ Failed (Inspect) Sep 4, 2024 4:50pm
staking-v2 ❌ Failed (Inspect) Sep 4, 2024 4:50pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
xc-admin-frontend ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 4:50pm

@guibescos guibescos changed the title Feat/update hermes to support publisher stake caps feat: update hermes to support publisher stake caps Sep 3, 2024
ali-bahjati
ali-bahjati requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I left some comments about some structural changes in the code. I think that publishers cap is not very compatible with the terminologies in Hermes and we need a larger refactor (probably later) to handle them.

apps/hermes/server/src/api.rs Outdated Show resolved Hide resolved
apps/hermes/server/src/api/types.rs Outdated Show resolved Hide resolved
apps/hermes/server/src/state/aggregate.rs Show resolved Hide resolved
@guibescos guibescos merged commit 1956d58 into main Sep 4, 2024
4 of 6 checks passed
@guibescos guibescos deleted the feat/update-hermes-to-support-publisher-stake-caps branch September 4, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-bahjati ali-bahjati ali-bahjati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guibescos @ali-bahjati