Add deprecation warning for 3.5 and lower #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 27, 2021 12:02
The messages might need adjustment, but the test is working.
I really hate black sometimes
fantix
reviewed
May 31, 2021
src/gino/__init__.py
Outdated
| .. versionchanged:: 1.1 | ||
| Added the ``prebake`` keyword argument to choose when to create the prepared | ||
| statements for the queries in the bakery: | ||
|
|
There was a problem hiding this comment.
I think this new line was to keep the markdown docs structure, the same for line 28.
There was a problem hiding this comment.
They had been removed by the formatter in my IDE. Has been fixed
Chaostheorie
changed the title
wwwjfy
requested changes
Jun 20, 2021
| @@ -14,10 +16,8 @@ | |||
| def create_engine(*args, **kwargs): | |||
| """ | |||
| Shortcut for :func:`sqlalchemy.create_engine` with ``strategy="gino"``. | |||
|
|
|||
There was a problem hiding this comment.
could you add these two lines back too?
| @@ -45,6 +45,15 @@ def get_version(): | |||
| return version("gino") | |||
|
|
|||
|
|
|||
| # Check if current python version is deprecated | |||
| # Check if version is lower than 3.6 | |||
There was a problem hiding this comment.
nitpick: this is quite obvious by the statement itself
|
I'll change the code as requested later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages might need adjustment, but the test is working. This PR is intended to resolve #731.