Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better implementation of at_least #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better implementation of at_least #25

wants to merge 1 commit into from

Conversation

quinor
Copy link

@quinor quinor commented Dec 20, 2018

The old one used two calls of times()

@quinor
Better implementation of at_least
518b7b1 
The old one used two calls of times()
@spookylukey
Copy link
Member

It looks like we don't really have good tests for at_least, and this would be a good opportunity to add them. Would you mind doing that?

@quinor
Copy link
Author

quinor commented Dec 21, 2018

I don't have the repository set up localy, I just fixed the bug on github and hoped it'd work straightaway... Could you do that for me instead?

@spookylukey
Copy link
Member

I'm afraid I'm extremely unlikely to merge changes that have not even been tested, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quinor @spookylukey