Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support saving CMYK JP2 images #8592

Merged
merged 5 commits into from
Dec 28, 2024

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Dec 10, 2024

Resolves #8062

Allows CMYK JP2 images to be saved. This functionality requires uclouvain/openjpeg#1529 from OpenJPEG 2.5.3.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this needs a docs update?

And let's add this to the release notes.

Comment on lines 576 to 580
``RGBA``, and ``YCbCr`` images with subsampled components. Pillow 10.4.0 and
later can read ``CMYK`` images with OpenJPEG 2.5.1 and later, and Pillow 11.1.0
and later can write ``CMYK`` images with OpenJPEG 2.5.3 and later. Pillow
supports JPEG 2000 raw codestreams (``.j2k`` files), as well as boxed JPEG 2000
files (``.jp2`` or ``.jpx`` files).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use the .. versionadded:: 10.4.0 etc. things?

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Dec 28, 2024
@radarhere radarhere merged commit 1a79d10 into python-pillow:main Dec 28, 2024
50 checks passed
@radarhere radarhere deleted the jpeg2000_cmyk_save branch December 28, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PRs that are ready JPEG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving a CMYK image as .jp2/.j2k fails
2 participants