Allow saving as BigTIFF #8642
Merged
Allow saving as BigTIFF #8642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
radarhere
commented
Dec 30, 2024
| @@ -582,7 +582,7 @@ class ImageFileDirectory_v2(_IFDv2Base): | |||
|
|
|||
| def __init__( | |||
| self, | |||
| ifh: bytes = b"II\052\0\0\0\0\0", | |||
| ifh: bytes = b"II\x2A\x00\x00\x00\x00\x00", | |||
There was a problem hiding this comment.
This is the same, I'm just changing it to the form seen elsewhere in this file.
radarhere
commented
Dec 30, 2024
| ifh = self._prefix + self._pack("H", 43 if self._bigtiff else 42) | ||
| if self._bigtiff: | ||
| ifh += self._pack("HH", 8, 0) | ||
| ifh += self._pack("Q", 16) if self._bigtiff else self._pack("L", 8) |
There was a problem hiding this comment.
See https://web.archive.org/web/20240706160214/https://www.awaresystems.be/imaging/tiff/bigtiff.html for a description of the header values.
hugovk
reviewed
Dec 30, 2024
docs/handbook/image-file-formats.rst
Outdated
| @@ -1208,6 +1208,9 @@ The :py:meth:`~PIL.Image.Image.save` method can take the following keyword argum | |||
|
|
|||
| .. versionadded:: 8.4.0 | |||
|
|
|||
| **bigtiff** | |||
There was a problem hiding this comment.
I suggest adding an underscore to the public API for readability (and in the code):
Suggested change
| **bigtiff** | |
| **big_tiff** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4669
Adds a keyword argument to allow TIFF images to be saved as BigTIFF -
im.save("out.tiff", big_tiff=True)