-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 766: Explicit Priority Choices Among Multiple Indexes (index priority) #4123
Conversation
Thanks for the help, @hugovk. |
Apply suggestions from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
4bb5cd9
to
d8a4033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some little nits
Thanks Hugo! Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Anything else needed here, @hugovk ? Barry explained to me that we should try to get this merged, then continue to revise the content according to discussions on discourse. |
Yep, if no-one has any comments let's merge! @warsaw: any final review suggestions, or good to merge? @msarahan Once merged, please open a new discussion topic, then open a quick PR to put that link under |
Is a new discussion topic necessary? I read that part of PEP 1, but I think the thread at https://discuss.python.org/t/pep-766-handling-multiple-indexes-index-priority/71589 fulfills the purpose described by PEP 1 of being a canonical discussion place, and the thread isn't terribly long (yet?) I feel like starting a new topic would only spread the existing discussion around more places. |
Good from my side, thanks @hugovk. I'll go ahead and merge. |
Yeah, this is why PEP 1 says to open the canonical discussion after merging the PR and getting the proper PEP URL.
Fair enough, please could you edit the top post to link to https://peps.python.org/pep-0766/ and not just this PR? |
Basic requirements (all PEP Types)
pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriate.github/CODEOWNERS
for the PEP📚 Documentation preview 📚: https://pep-previews--4123.org.readthedocs.build/pep-0766/