change pmt require grad to false when detached #3525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67563018 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D67563018 |
Summary: X-link: facebookresearch/FBGEMM#607 after calling tensor.detach, tensor.require_grad will automatically switch to false, following the same pattern in PMT tensor Reviewed By: jiayulu Differential Revision: D67563018
duduyi2013
force-pushed
the
export-D67563018
branch
from
a5bd78c to
6389872
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67563018 |
|
This pull request has been merged in 7d31824. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: after calling tensor.detach, tensor.require_grad will automatically switch to false, following the same pattern in PMT tensor
Differential Revision: D67563018